Merge pull request #32228 from hregis/fix_dev_wrong_entity_param_value

FIX wrong param entity value
Dolibarr · Dec 4, 2024 · b41ef21 · b41ef21
2 parents 56173b0 + 9aa4ce7
commit b41ef21
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/htdocs/bom/bom_net_needs.php b/htdocs/bom/bom_net_needs.php
@@ -201,6 +201,7 @@
 	$object->fetch_product();
 	$manufacturedvalued = '';
 	if (!empty($object->product)) {
+		global $mysoc;
 		$tmparray = $object->product->getSellPrice($mysoc, $mysoc);
 		$manufacturedvalued = $tmparray['pu_ht'] * $object->qty;
 	}

diff --git a/htdocs/core/login/functions_googleoauth.php b/htdocs/core/login/functions_googleoauth.php
@@ -53,7 +53,7 @@ function check_user_password_googleoauth($usertotest, $passwordtotest, $entityto
 
 			// We save data of form into a variable
 			$_SESSION['datafromloginform'] = array(
-				'entity'=>GETPOSTINT('entity'),
+				'entity'=>GETPOST('entity', 'int'), // avoid to return 0 if entity var not exists
 				'backtopage'=>GETPOST('backtopage'),
 				'tz'=>GETPOST('tz'),
 				'tz_string'=>GETPOST('tz_string'),

diff --git a/htdocs/core/modules/oauth/generic_oauthcallback.php b/htdocs/core/modules/oauth/generic_oauthcallback.php
@@ -334,7 +334,7 @@
 					dol_syslog("we received the login/email to log to, it is ".$useremail);
 
 					$tmparray = (empty($_SESSION['datafromloginform']) ? array() : $_SESSION['datafromloginform']);
-					$entitytosearchuser = (isset($tmparray['entity']) ? $tmparray['entity'] : -1);
+					$entitytosearchuser = ((isset($tmparray['entity']) && $tmparray['entity'] != '') ? $tmparray['entity'] : -1);
 
 					// Delete the old token
 					$storage->clearToken($genericstring);	// Delete the token called ("Generic-".$storage->keyforprovider)

diff --git a/htdocs/core/modules/oauth/google_oauthcallback.php b/htdocs/core/modules/oauth/google_oauthcallback.php
@@ -324,7 +324,7 @@
 					dol_syslog("we received the login/email to log to, it is ".$useremail);
 
 					$tmparray = (empty($_SESSION['datafromloginform']) ? array() : $_SESSION['datafromloginform']);
-					$entitytosearchuser = (isset($tmparray['entity']) ? $tmparray['entity'] : -1);
+					$entitytosearchuser = ((isset($tmparray['entity']) && $tmparray['entity'] != '') ? $tmparray['entity'] : -1);
 
 					// Delete the old token
 					$storage->clearToken('Google');	// Delete the token called ("Google-".$storage->keyforprovider)