Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make field date_start accessable for GETPOST in proposal #27063

Merged
merged 2 commits into from
Nov 13, 2024
Merged

make field date_start accessable for GETPOST in proposal #27063

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50bbe66
make field date_delivery accessible for GETPOST in proposal
cfoellmann Dec 14, 2023
c61db73
Merge branch 'develop' into 19/PR/proposal-hookable-deliverydate
eldy Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion htdocs/comm/propal/card.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2008,7 +2008,8 @@
$sday = date("d", $tmpdte);
print $form->selectDate($syear."-".$smonth."-".$sday, 'date_livraison', '', '', '', "addprop");
} else {
print $form->selectDate(-1, 'date_livraison', '', '', '', "addprop", 1, 1);
$tmp_date_delivery = GETPOST('date_delivery') ? : -1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getpost key name is 'date_delivery'
But name of field 'date_livraison'
Should not be the same ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that everything should be English and whenever possible.
But if you insist on changing this I can

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think too that we must migrate step by step to english. But whatever is language, the name of variable must be consistent in all page.
So if the name of param is xxx for assignement, you should use xxx to read it. But here, there is 2 different name. Is it done on purpose ?

print $form->selectDate($tmp_date_delivery, 'date_livraison', '', '', '', "addprop", 1, 1);
}
print '</td></tr>';

Expand Down
Loading