Qual: Improve write_file typing (part 2) #30527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mdeweerd |
mdeweerd
force-pushed
the
write_file_issues
branch
5 times, most recently
from
bb97f0d
to
04bb40d
Compare
mdeweerd
force-pushed
the
write_file_issues
branch
3 times, most recently
from
6a3523b
to
c779521
Compare
mdeweerd
force-pushed
the
write_file_issues
branch
from
c779521
to
535981a
Compare
mdeweerd
force-pushed
the
write_file_issues
branch
2 times, most recently
from
e491e20
to
32d822e
Compare
mdeweerd
force-pushed
the
write_file_issues
branch
from
32d822e
to
6b3f84f
Compare
mdeweerd
force-pushed
the
write_file_issues
branch
2 times, most recently
from
5538801
to
6b7abd7
Compare
And update phpdoc for derived classes
And update phpdoc for derived classes
And update phpdoc for derived classes
And update phpdoc for derived classes
mdeweerd
force-pushed
the
write_file_issues
branch
2 times, most recently
from
91cb1be
to
05e416d
Compare
mdeweerd
force-pushed
the
write_file_issues
branch
from
05e416d
to
a0f6c1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Qual: Improve write_file typing (part 2)
This was part of #30511, but the typing hints highlight issues that need decisions best made/implemented by @eldy I think (which I moved them to this separate PR).