Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW third-party name in tooltip of linkedobject templates #31100

Conversation

lvessiller-opendsi
Copy link
Contributor

NEW third-party name in tooltip of linkedobject templates

@eldy
Copy link
Member

eldy commented Sep 26, 2024

Because the load of thirdparty may need a fetch and because the getNomUrl is a low level function that can be called frequently inside a loop, so the load of the thirdparty must not be done inside the getNomUrl (except if function is called to show the tooltip using ajax).
Why not just showing the thirdparty if the $this->thirdparty object is defined.
It will be the decision to the caller to load or not the thirdparty()

@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Sep 26, 2024
@lvessiller-opendsi
Copy link
Contributor Author

I would have liked to have the third-party name in linked objects, but it seems not the good way to do.
If third-party is not already fetched, it won"t be show in the tooltip.
So I will change the way to do it.

@lvessiller-opendsi lvessiller-opendsi deleted the new-linkedobject-tooltip-with-thirdparty-name branch September 27, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants