Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: PDF Invoice show vat analysis per rate #31381

Merged
merged 23 commits into from
Nov 13, 2024

Conversation

sonikf
Copy link
Contributor

@sonikf sonikf commented Oct 13, 2024

All credit goes to user Franck Moreau for submitting code.

https://discord.com/channels/529709484797591563/529709484797591565/1270365722664632403

01

@sonikf sonikf changed the title NEW: PDF Show vat analysis per rate NEW: PDF Invoice show vat analysis per rate Oct 13, 2024
@sonikf
Copy link
Contributor Author

sonikf commented Oct 16, 2024

Hi @eldy

Any estimate on feature freeze date?

I would like to add 2 more features(already tested) for this cycle if you approve

  1. if discount exists add total in all related templates(proposal, sales order) by default and remove hidden parameters
    https://github.com/Dolibarr/dolibarr/blob/d527f05041a9c57618b0180c5d9534ddbabf6633/htdocs/core/modules/facture/doc/pdf_sponge.modules.php#L1659C1-L1679C4

  2. options to hide frames from all other boxes and option to hide all frames in all templates

@eldy
Copy link
Member

eldy commented Oct 19, 2024

Hi @eldy

Any estimate on feature freeze date?

I would like to add 2 more features(already tested) for this cycle if you approve

  1. if discount exists add total in all related templates(proposal, sales order) by default and remove hidden parameters
    https://github.com/Dolibarr/dolibarr/blob/d527f05041a9c57618b0180c5d9534ddbabf6633/htdocs/core/modules/facture/doc/pdf_sponge.modules.php#L1659C1-L1679C4

  2. options to hide frames from all other boxes and option to hide all frames in all templates

Hope freeze before end of month, so in 1 week, but there is still a lot of pending pr to merge... You can submit even during freeze, in worst case, pr will be set to Pending status...

@eldy eldy merged commit 1f2bb29 into Dolibarr:develop Nov 13, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants