Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : Hidden dropdown download link in project #32102

Merged
merged 4 commits into from
Dec 19, 2024
Merged

FIX : Hidden dropdown download link in project #32102

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
46581d5
FIX : Hidden dropdown download link in project
atm-irvine Nov 26, 2024
caabaab
Added table for handling tdoverflowmax
atm-irvine Nov 28, 2024
ca51c23
Merge branch '20.0' into fix_hidden_dropdown_download_link_in_project
eldy Dec 3, 2024
a728c2c
Merge branch '20.0' into fix_hidden_dropdown_download_link_in_project
eldy Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion htdocs/projet/element.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1295,10 +1295,11 @@
print "</td>\n";

// Ref
print '<td class="left nowraponall tdoverflowmax250">';
print '<td class="left nowraponall">';
Copy link
Member

@eldy eldy Nov 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need the tdoverflowmax250 for the case of object that do have a download arrwo and output a very long ref including a text (like loan , tasks).
The ref and is combo must alwyas be in a separated column so i suggest to split the td in 2. The first one with ref and link will be without the tdoverflow. The second that contains the very long text will have the tdoverflowmax250.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put a table inside the td to prevent adding another td because the table head would not be right.

if ($tablename == 'expensereport_det') {
print $expensereport->getNomUrl(1);
} else {
print '<table><tr><td style="border-bottom: none;">';
// Show ref with link
if ($element instanceof Task) {
print $element->getNomUrl(1, 'withproject', 'time');
Expand Down Expand Up @@ -1334,6 +1335,10 @@
}
print '</div>';

print '</td>';

print '<td class="tdoverflowmax250" style="border-bottom: none;">';

// Show supplier ref
if (!empty($element->ref_supplier)) {
print ' - '.$element->ref_supplier;
Expand All @@ -1346,6 +1351,8 @@
if (empty($element->ref_customer) && !empty($element->ref_client)) {
print ' - '.$element->ref_client;
}

print '</td></tr></table>';
}
print "</td>\n";
// Product and qty on stock movement
Expand Down
Loading