Improve parameter validation #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
Jul 21, 2022
kocsismate
force-pushed
the
param-validation
branch
from
f5bc8f0 to
9b7fcfb
Compare
Merged
kocsismate
force-pushed
the
param-validation
branch
from
9b7fcfb to
b63f8c7
Compare
kocsismate
commented
Aug 17, 2022
| #if PHP_VERSION_ID >= 80000 | ||
| zend_argument_error(NULL, 3, "must be a power of 2"); | ||
| #else | ||
| zend_throw_error(zend_ce_error, "scrypt(): Argument #3 ($N) must be a power of 2"); |
There was a problem hiding this comment.
spaces and tabs are currently mixed, so I'll fix this later as a followup PR.
kocsismate
force-pushed
the
param-validation
branch
2 times, most recently
from
40833df to
d94c5c4
Compare
Instead of triggering fatal errors, Error exceptions are now thrown when a parameter is invalid. Error messages are changed so that they are now in line PHP 8 conventions.
kocsismate
force-pushed
the
param-validation
branch
from
d94c5c4 to
f9ce7e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of triggering fatal errors,
Errorexceptions are now thrown when a parameter is invalid. Error messages are changed so that they are now in line PHP 8 conventions.