Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify ambiguity on notifications #80

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Conversation

gromgit
Copy link
Contributor

@gromgit gromgit commented Feb 7, 2022

"Experimental notifier runs automatically" doesn't necessarily imply that notifications are enabled automatically.

Addreses Homebrew/discussions#2915 (reply in thread).

"Experimental notifier runs automatically" doesn't necessarily imply that _notifications_ are enabled automatically.

Addreses Homebrew/discussions#2915 (reply in thread).
Copy link
Contributor

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @gromgit!

@DomT4
Copy link
Owner

DomT4 commented Feb 11, 2022

Seems alright to me. Hoping people don't take the removal of the mention of that lack of external dependencies to mean this now mandates terminal-notifier on newer versions of macOS, we'll see what the feedback is.

@DomT4 DomT4 merged commit dfb2bdc into DomT4:master Feb 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants