Merge upstream react slick #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing issue with asNavFor not detecting all slide changes
…d be deprecated for the following reasons: https://wesbos.com/let-vs-const/ and https://mathiasbynens.be/notes/es6-const
updated var(s) to let and const
Fixes the asNavFor issue when infinite is false. fixed #1562
fix: non-existed lifecycle UNSAFE_componentWillUnmount
Added style props to the component allowing to user to pass inline styles
the last browsers requiring webkit vendor prefix is about 6years ago. it's good enough to remove it.
There is no case componentDidMount that will be called on server side. Good to not have the guard
refactor: no componentDidMount called on server
refactor: remove deprecated vendor prefix
fix the afterChange-test
fixed #1830
In some cases, for instance while running some tests via storyshot, we can get a blocker with this error message: `Error: Uncaught [TypeError: Cannot read property 'querySelectorAll' of undefined]` Adding `this.list &&` at the beginning of this test will avoid such of issues and let pass well the tests I would really appreciate that fix to be able to move forward from `0.25.2` of react-slick to the latest version Thanks
…TouchMove, onTouchStart
Need to enforce images list validation
…ents: onTouchMove, onTouchStart" This reverts commit cc5341f.
… in last commit. Implemented new method.
… they are passive.
Support disable bounce for vertical mode
ghost
force-pushed
the
merge-upstream-react-slick
branch
from
14b10f1 to
f44a8fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge react-slick (https://github.com/akiran/react-slick) to our forked version. I've updated a couple of components to use beta version then to fe-pa and it's now on the server, see this preview link https://fe-server-search-listings-f5caa24a.pre.domain.com.au/sale/
Changes - akiran/react-slick@0.23.2...master our master has 0.23.2 from react-slick
React-slick release page - https://github.com/akiran/react-slick/releases
https://github.com/domain-group/fe-co-carousel/pull/54
https://github.com/domain-group/fe-co-listing-card/pull/440