-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derpibooru csv and colors update #293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for the strange key numbering here was that back when derpibooru tags were first added, they started category numbering at 1 and used 2 for general tags. I'm not sure if this was actually the APIs fault or just a mistake of the user that submitted them, but I changed all tags of cat 2 to 0 to match danboorus general tags (color-wise). Since the other numbers seemed to match the API output, I didn't shift them back to fill the empty spot left by 2.
This might not seem like an issue since you used the correct numbers in your updated CSV. But the color changes here are only the option default. Without resetting them manually, users would suddenly see a lot of wrong colors after updating, since their options are already applied and keep the old values. That means all tags you currently have marked with cat 2 will show as invalid for existing users, with the -1 color being used.
Sadly there isn't a way in place to inform the user about changed defaults at this time, I think the webui itself dealt with this by just renaming the option so that the old saved values get ignored. But I'm not too happy with this approach, as it would also undo all custom colors people might have set up for themselves (although I don't know if many did so). What do you think?
Well, the problem with derpi categories is that they don't really have ids, they're just stored in the "tags" table as plain text with NULL meaning "general" category. I based the numbering just off of alphabetical sorting. So, I've reviewed the old csv and currently the mapping looks like this:
Which, as you explained, will mess up the coloring with no obvious way for the user to fix it. So, what I'm thinking is:
I'm not insisting on adjusting colors, btw. Just thought it would be a nice touch :) At least for the new or more attentive users. Let me know if you want me to revert this. |
Alright, that should take care of that. Categories renumbered and color changes removed. |
Sorry to keep bothering you, one more thing: Since normal tags don't get re-sorted in most cases, that would push a lot of matches further down or even outside of the max cap, so that is pretty important to fix. |
No problem. Should be ordered by tag count now. |
Up-to-date Derpibooru tags as of 2024-07-04 neatly sorted by category and image count + added tag aliases + default tag coloration updated to match the booru's dark and light themes respectively. Only includes tags with at least 10 images. "Spoiler" category was not included, as there was only ~300 entries total and I can not imagine a scenario where it can be useful for prompting.