Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MultiSelect growing vertically #1020

Closed
Ri-gers opened this issue Mar 13, 2025 · 4 comments
Closed

Fix MultiSelect growing vertically #1020

Ri-gers opened this issue Mar 13, 2025 · 4 comments
Assignees
Milestone

Comments

@Ri-gers
Copy link

Ri-gers commented Mar 13, 2025

Image

Allow for MultiSelect to prevent growing automatically in vertical direction if too many items are selected. So even if not all selected items fit into the field, let the component keep its initial look. For example in the picture display a "...", "and more", etc. after Denmark or Croatia to indicate that there are more values selected than displayed.
This is helpful if below the MultiSelect component there are other form fields which get pushed further down and make the form's layout look weird.

@vegegoku vegegoku self-assigned this Mar 13, 2025
@github-project-automation github-project-automation bot moved this to To do in Domino UI Mar 13, 2025
@vegegoku vegegoku added this to the 2.0.4 milestone Mar 13, 2025
@Ri-gers
Copy link
Author

Ri-gers commented Mar 13, 2025

@vegegoku is this really a bug? Was MultiSelect never intended to grow vertically? (I'm not talking about the dashes that seem to be misplaced if more than one line needs to be displayed by the way)

@vegegoku
Copy link
Member

@vegegoku is this really a bug? Was MultiSelect never intended to grow vertically? (I'm not talking about the dashes that seem to be misplaced if more than one line needs to be displayed by the way)

It should not grow, at least not by default, and the dashes thing is only present in demo and is not part of the component, its made with css, users can do there own splitting.

@Ri-gers
Copy link
Author

Ri-gers commented Mar 13, 2025

@vegegoku is this really a bug? Was MultiSelect never intended to grow vertically? (I'm not talking about the dashes that seem to be misplaced if more than one line needs to be displayed by the way)

It should not grow, at least not by default, and the dashes thing is only present in demo and is not part of the component, its made with css, users can do there own splitting.

Oh okay, I always thought it was a feature, then it's fine :)

@Ri-gers Ri-gers changed the title Add option to fix a MultiSelect's vertical dimension Fix MultiSelect growing vertically Mar 13, 2025
@vegegoku
Copy link
Member

New options added to allow wrapping - default to no wrap - setWrapSelection(boolean wrapSelection)
also added an option to show selected options count - not visible by default - setShowSelectionCount(boolean showSelectionCount)

vegegoku added a commit that referenced this issue Mar 19, 2025
@github-project-automation github-project-automation bot moved this from To do to Done in Domino UI Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants