Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalListScrollingDataStore does not invoke 'load()' at the end of its setData method. #653

Closed
NickGaens opened this issue May 11, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request version 2.x.x Version 2.x.x issues
Milestone

Comments

@NickGaens
Copy link

NickGaens commented May 11, 2022

Describe the bug
The method setData(List<T> data) of LocalListScrollingDataStore does not invoke load() at the end of its body.

Expected behavior
The invocation of the load() method should be present.

Additional context
This is the setData method of LocalListDataStore:

/**
   * sets new data list overriding the existing one, and clears all filters, then loads it in the
   * data table
   *
   * @param data the new {@link List} of records
   */
  public void setData(List<T> data) {
    this.original.clear();
    this.original.addAll(data);
    this.filtered.clear();
    this.filtered.addAll(original);
    load();
  }

and this is the one from LocalListScrollingDataStore:

/**
   * sets new data list overriding the existing one, and clears all filters, then loads it in the
   * data table
   *
   * @param data the new {@link List} of records
   */
  public void setData(List<T> data) {
    this.original.clear();
    this.original.addAll(data);
    this.filtered.clear();
    this.filtered.addAll(original);
  }
@vegegoku vegegoku self-assigned this Oct 20, 2024
@vegegoku vegegoku added the enhancement New feature or request label Oct 20, 2024
@github-project-automation github-project-automation bot moved this to To do in Domino UI Oct 20, 2024
@vegegoku vegegoku added this to the 2.0.4 milestone Oct 20, 2024
vegegoku added a commit that referenced this issue Nov 10, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Domino UI Nov 10, 2024
@vegegoku vegegoku added the version 2.x.x Version 2.x.x issues label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request version 2.x.x Version 2.x.x issues
Projects
Status: Done
Development

No branches or pull requests

2 participants