Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs added to the DOM by FileUpload never removed #744

Closed
lleprieur opened this issue Jan 2, 2023 · 0 comments
Closed

Inputs added to the DOM by FileUpload never removed #744

lleprieur opened this issue Jan 2, 2023 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lleprieur
Copy link

lleprieur commented Jan 2, 2023

Describe the bug
A component inheriting FileUpload creates a hidden input in the DOM each time the page is loaded. It doesn't cause performance issue or any problems but it floods the DOM with numerous elements which shouldn’t exist.

To Reproduce
If one would like to reproduce the error, he would need a GWT client app with a form using FileUpload class.

  1. Load the page with chrome dev tools opened to the HTML code
  2. Reload the page by navigating to it (link to the page for example)
  3. See the DOM being filled by unexpected inputs

Expected behavior
No more input should be added to the DOM

Screenshots
Capture d’écran 2022-12-14 à 16 44 28

Method from the class FileUpload being called on super()
Capture d’écran 2023-01-02 à 12 07 04

Desktop (please complete the following information):

  • OS: Mac OS Monterey 12.6
  • Browser Chrome 108.0.5359.124
  • Version domino-ui-shared-1.0.0-RC13
@vegegoku vegegoku self-assigned this Jan 3, 2023
@vegegoku vegegoku added the bug Something isn't working label Jan 3, 2023
@vegegoku vegegoku added this to the 1.0.0-RC15 milestone Jan 3, 2023
@vegegoku vegegoku closed this as completed Jan 3, 2023
@vegegoku vegegoku changed the title Inputs added to the DOM by FileUpload class Inputs added to the DOM by FileUpload never removed Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants