Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Disabled MenuItem still receive events #769

Closed
jhickman opened this issue Mar 7, 2023 · 2 comments
Closed

Bug: Disabled MenuItem still receive events #769

jhickman opened this issue Mar 7, 2023 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jhickman
Copy link

jhickman commented Mar 7, 2023

Disabled menu items appear to have the style applied, but will still execute the click handlers.

sample code:

Button.create("click")
  .setDropMenu(Menu.create()
    .appendChild(MenuItem.create("Test")
      .disable()
      .addClickListener(evt -> DomGlobal.alert("fail"))
    )
  )
@vegegoku vegegoku self-assigned this Mar 8, 2023
@vegegoku vegegoku added the bug Something isn't working label Mar 8, 2023
@vegegoku vegegoku added this to the 1.0.0-RC18 milestone Mar 8, 2023
@vegegoku
Copy link
Member

vegegoku commented Mar 8, 2023

Trying to reproduce this and it seems the clickListeners does not work after disable but Selection listeners still working.

@jhickman
Copy link
Author

fix LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants