Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TagBox: readonly tag will not be removed #848

Closed
philkohl opened this issue Oct 1, 2023 · 0 comments
Closed

TagBox: readonly tag will not be removed #848

philkohl opened this issue Oct 1, 2023 · 0 comments
Assignees
@vegegoku
Labels
bug Something isn't working version 2.x.x Version 2.x.x issues
Milestone
2.0.0-RC4

Comments

@philkohl
Copy link

philkohl commented Oct 1, 2023

Describe the bug
Making TagBox readonly, makes the TagBox not be editable anymore.

To Reproduce

  1. Create TagBox: TagBox tagBox = TagBox.create("Tags", token -> token);
  2. TagBox can be edited
  3. Make TagBox readonly: tagBox.setReadOnly(true);
  4. TagBox not editable as expected.
  5. Make TagBox not readonly: tagBox.setReadOnly(false);
  6. TagBox is still not editable.

Possible Cause
Could be the hardcoded true at the following place?

domino-ui/domino-ui/src/main/java/org/dominokit/domino/ui/forms/suggest/TagBox.java

Line 262 in 06571b9

this.getInputElement().setReadOnly(true);

@vegegoku vegegoku self-assigned this Oct 2, 2023
@vegegoku vegegoku added bug Something isn't working version 2.x.x Version 2.x.x issues labels Oct 2, 2023
@vegegoku vegegoku added this to the 2.0.0-RC4 milestone Oct 2, 2023
vegegoku added a commit that referenced this issue Oct 2, 2023
@vegegoku
fix #848 TagBox: readonly tag will not be removed
66b1683
@vegegoku vegegoku closed this as completed Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vegegoku vegegoku

Labels
bug Something isn't working version 2.x.x Version 2.x.x issues
Projects
Domino UI
Status: Done
Milestone
2.0.0-RC4
Development

No branches or pull requests
2 participants
@vegegoku @philkohl