Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SummeryPlugin SummaryRow is not being cleared and is duplicated instead #851

Closed
FrankHossfeld opened this issue Oct 7, 2023 · 0 comments
Assignees
Labels
bug Something isn't working version 2.x.x Version 2.x.x issues
Milestone

Comments

@FrankHossfeld
Copy link
Contributor

FrankHossfeld commented Oct 7, 2023

Using the SummaryPlugin on a DataTable, you got something like that:

Bildschirmfoto 2023-10-07 um 23 28 56

Now, calling setData() again, will create a new SummayRow, but does not delete the old one:

Bildschirmfoto 2023-10-07 um 23 36 32

Changing:

private List<TableRow<T>> summaryRows = new ArrayList<>();

to

private List<SummaryRow<T, S>> summaryRows = new ArrayList<>();

and adding:

summaryRows.add(summaryRow);

inside the loop of the setSummaryRecords-method will solve the issue.

@FrankHossfeld FrankHossfeld changed the title v2 SummeryPlugin -> summery row gets not cleared v2: SummeryPlugin -> summery row gets not cleared Oct 7, 2023
@FrankHossfeld FrankHossfeld changed the title v2: SummeryPlugin -> summery row gets not cleared v2: SummeryPlugin -> SummaryRow gets not cleared Oct 7, 2023
@vegegoku vegegoku self-assigned this Oct 29, 2023
@vegegoku vegegoku added the bug Something isn't working label Oct 29, 2023
@vegegoku vegegoku added this to the 2.0.0-RC4 milestone Oct 29, 2023
@vegegoku vegegoku added the version 2.x.x Version 2.x.x issues label Oct 29, 2023
@vegegoku vegegoku changed the title v2: SummeryPlugin -> SummaryRow gets not cleared SummeryPlugin SummaryRow is not being cleared and is duplicated instead Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working version 2.x.x Version 2.x.x issues
Projects
Status: Done
Development

No branches or pull requests

2 participants