Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiSelect#clear(silent) doesn't deselect silently #916

Closed
howudodat opened this issue Feb 13, 2024 · 0 comments
Closed

MultiSelect#clear(silent) doesn't deselect silently #916

howudodat opened this issue Feb 13, 2024 · 0 comments
Assignees
@vegegoku
Labels
bug Something isn't working version 2.x.x Version 2.x.x issues
Milestone
2.0.1

Comments

@howudodat
Copy link

Another possible bug???

MultiSelect#clear(true)  (Actually in AbstractSelect) 
  -> AbstractSelect#clearValue(true)
  -> line 265 forEach(AbstractMenuItem::deselect)

doesn't pass on the silent flag and as a result calls the change handlers again
@vegegoku vegegoku self-assigned this Mar 18, 2024
@vegegoku vegegoku added bug Something isn't working version 2.x.x Version 2.x.x issues labels Mar 18, 2024
@vegegoku vegegoku added this to the 2.0.1 milestone Mar 18, 2024
vegegoku added a commit that referenced this issue Apr 14, 2024
@vegegoku
fix #916 MultiSelect#clear(silent) doesn't deselect silently
88aef41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vegegoku vegegoku

Labels
bug Something isn't working version 2.x.x Version 2.x.x issues
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
2 participants
@howudodat @vegegoku