Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance some behaviors for DateBox/TimeBox/Calendar. #936

Closed
salashnik opened this issue May 17, 2024 · 0 comments
Closed

Enhance some behaviors for DateBox/TimeBox/Calendar. #936

salashnik opened this issue May 17, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request version 2.x.x Version 2.x.x issues
Milestone

Comments

@salashnik
Copy link
Contributor

  1. in Calendar DATE_NAVIGATION_CHANGED event listener

this.date = updatedDate;
must be before
onDateViewUpdate(updatedDate);

causes strange behaviour when months changed

  1. in DateBox calendar.setDate must be called before popover open, like this:
    private void doOpen() {
        if (isEnabled() && !isReadOnly()) {
            calendar.setDate(value);
            popover.open();
        }
    }

currently popup dont respect value entered from keyboard

  1. in Calendar.setDate
calendarMonth.show();
yearMonthPicker.hide();

must be called (like this):

    public Calendar setDate(final Date date) {
        final Date oldDate = this.date;
        this.date = date;
        if (nonNull(date)) {
            onDateViewUpdate(this.date);
            onDateSelectionChanged(this.date);
            calendarMonth.show();
            yearMonthPicker.hide();
            triggerChangeListeners(oldDate, this.date);
        }
        return this;
    }

currently opens in last selected page

  1. changehandler in DateBox (and TimeBox too) do not respect label
                    if (parseStrict) {
                        invalidate("Unable to parse date value " + value);
                    }

must be changed to

                    if (parseStrict) {
                        invalidate(getLabels().calendarInvalidDateFormat());
                    }

like validator check does

@salashnik salashnik changed the title few proposed fixes for DateBox/TimeBox/Calendar few proposed fixes for DateBox/TimeBox/Calendar (domino-ui v2) May 17, 2024
@vegegoku vegegoku self-assigned this Jun 25, 2024
@vegegoku vegegoku added enhancement New feature or request version 2.x.x Version 2.x.x issues labels Jun 25, 2024
@vegegoku vegegoku added this to the 2.0.2 milestone Jun 25, 2024
@vegegoku vegegoku changed the title few proposed fixes for DateBox/TimeBox/Calendar (domino-ui v2) few proposed fixes for DateBox/TimeBox/Calendar Jul 29, 2024
@vegegoku vegegoku changed the title few proposed fixes for DateBox/TimeBox/Calendar Fix wrong behaviors for DateBox/TimeBox/Calendar Jul 29, 2024
@vegegoku vegegoku changed the title Fix wrong behaviors for DateBox/TimeBox/Calendar Enhance some behaviors for DateBox/TimeBox/Calendar. Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request version 2.x.x Version 2.x.x issues
Projects
Status: Done
Development

No branches or pull requests

2 participants