Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select inner divs overlap outer divs height #945

Closed
bschmelcher opened this issue Jun 21, 2024 · 2 comments
Closed

Select inner divs overlap outer divs height #945

bschmelcher opened this issue Jun 21, 2024 · 2 comments
Assignees
Labels
bug Something isn't working version 1.x.x Version 1.x.x issues
Milestone

Comments

@bschmelcher
Copy link

Describe the bug
Using domino-ui version 1.0.6, the inner divs of Selects overlap the outer div in height, because no height:100% is set for the inner divs.
For the div with class field-cntr inside the select-div, a fixed height is set by domino-ui-components.css
For the divs inside the field-cntr div, no height is set. So the inner divs(flex-layout and field-input-cntr) can overlap the outer div.
The issue is getting worse when the line-height property of flex-layout is being changed.

This issue can be observed without any DOM/CSS modifications with the newest Chrome-Version (126.0.6478.115). It's also present in domino-ui-demo. I'm not exactly sure why this occured now with the Chromium-Update, but changing the line-height of the table in Firefox also will lead to the same issue.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://dominokit.com/domino-ui/demo/v1/datatable/mix-plugins
  2. See the Filter Selects at the top of the table

Expected behavior
Inner divs should not overlap outer divs in Select

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows
  • Browser [e.g. stock browser, safari]
  • Version: 126.0.6478.115

Additional context
Setting the height of the flex-layout and field-input-cntr divs of the select to 100% fixes this.

@vegegoku vegegoku self-assigned this Jun 25, 2024
@vegegoku vegegoku added bug Something isn't working version 1.x.x Version 1.x.x issues labels Jun 25, 2024
@vegegoku vegegoku added this to the 2.0.2 milestone Jun 25, 2024
@vegegoku vegegoku changed the title Select inner divs overlap outer divs height (domino-ui v1.0.6) Select inner divs overlap outer divs height Jul 26, 2024
@MarkusAchenbach
Copy link

HI,
will there be a backport to v1.x.x ? (would be highly appreciated)

@FrankHossfeld
Copy link
Contributor

FrankHossfeld commented Aug 21, 2024

Hi Markus,
it looks like the changes are made in the 1.0.0-development branch. So, no action required.
cu Frank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working version 1.x.x Version 1.x.x issues
Projects
Status: Done
Development

No branches or pull requests

4 participants