Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong weekend day are marked as weekend #961

Closed
schube opened this issue Sep 18, 2024 · 1 comment
Closed

Wrong weekend day are marked as weekend #961

schube opened this issue Sep 18, 2024 · 1 comment
Assignees
@vegegoku
Labels
bug Something isn't working version 2.x.x Version 2.x.x issues
Milestone
2.0.3

Comments

@schube
Copy link
Contributor

schube commented Sep 18, 2024

Describe the bug
I am using org.dominokit.domino.ui.datepicker.Calendar from DominoUI v2 (HEAD-SNAPSHOT).
It detects my locale automatically which is German.
In Germany (and Austria), the first day of the week is Monday (unlike in the US, where it is Sunday).
The calendar renders correctly with Monday being the first column. But Monday is marked as a weekend, where Saturday is not.
See screenshot attached.
The CSS class dui-mark-weekend-day is added with your plugin from https://github.com/DominoKit/domino-ui/issues/946
The main problem is likely located in CalendarDay::isWeekend. I do not really understand the code there, so I cannot post a fix, sorry.

CleanShot 2024-09-18 at 09 21 28@2x

Thank you!
@vegegoku vegegoku self-assigned this Sep 18, 2024
@vegegoku vegegoku added the bug Something isn't working label Sep 18, 2024
@github-project-automation github-project-automation bot moved this to To do in Domino UI Sep 18, 2024
@vegegoku vegegoku added the version 2.x.x Version 2.x.x issues label Sep 18, 2024
@vegegoku vegegoku added this to the 2.0.3 milestone Sep 18, 2024
@vegegoku vegegoku changed the title Calendar, Monday is marked as weekend in German locale Wrong weekend day are marked as weekend Sep 19, 2024
vegegoku added a commit that referenced this issue Sep 19, 2024
@vegegoku
fix #961 Wrong weekend day are marked as weekend
81d2d90
@github-project-automation github-project-automation bot moved this from To do to Done in Domino UI Sep 19, 2024
@schube
Copy link
Contributor Author

schube commented Sep 19, 2024

Thank you for your quick fix!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vegegoku vegegoku

Labels
bug Something isn't working version 2.x.x Version 2.x.x issues
Projects
Domino UI
Status: Done
Milestone
2.0.3
Development

No branches or pull requests
2 participants
@vegegoku @schube