Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable GroupingPlugin improvements #641

Merged
merged 2 commits into from
Mar 15, 2022
Merged

DataTable GroupingPlugin improvements #641

merged 2 commits into from
Mar 15, 2022

Conversation

salashnik
Copy link
Contributor

make getDataGroups method and DataGroup class public
move cell content rendering code to DataGroup (render method)

this makes possibility re-render group cell if needed ;-)

@vegegoku vegegoku self-requested a review March 15, 2022 22:00
@vegegoku vegegoku self-assigned this Mar 15, 2022
@vegegoku vegegoku added the enhancement New feature or request label Mar 15, 2022
@vegegoku vegegoku added this to the 1.0.0-RC11.1 milestone Mar 15, 2022
@vegegoku vegegoku merged commit 26e4829 into DominoKit:development Mar 15, 2022
vegegoku pushed a commit that referenced this pull request Jun 6, 2022
@salashnik
DataTable GroupingPlugin improvements (#641)
d83a525 
* DataTable GroupingPlugin improvements

* fix formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegegoku vegegoku Awaiting requested review from vegegoku

Assignees

@vegegoku vegegoku

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@salashnik @vegegoku