Strongly type createTerminal #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tyriar , thanks |
DonJayamanne
added a commit
that referenced
this pull request
Nov 28, 2017
… setting (#312) Fixes #285 * This setting is deprecated in favour of the standard vs code setting to enable the feature of formattig on save. * Also took the liberty of refactoring some files (reduces code review for re-engineering of execution engine). * Removed unused file 'windowsService.ts'
DonJayamanne
added a commit
that referenced
this pull request
Nov 28, 2017
* upstream/master: Remove setting python.formatting.formatOnSave in favor of the vs code setting (#312)
DonJayamanne
added a commit
that referenced
this pull request
Nov 29, 2017
* master: Remove setting linting.lintOnTextChange as it was never implemented (#315) Remove setting python.formatting.formatOnSave in favor of the vs code setting (#312) Remove jupyter functionality in favor of Jupyter extension (#302) Drop Python 2 URLs (#307) Fix debugging tests (#304)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that v1.5 is stable we can strongly type the Terminal API.