Fix sys.path changes for use of bundled jedi #381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path to bundled jedi was appended to sys.path instead of prepended, which means if user had a different jedi version installed that would be used instead. Also, we pop the 0'th element after the jedi import, so it it was previously incorrect and would pop the wrong entry from sys.path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path to bundled jedi was appended to sys.path instead of prepended,
which means if user had a different jedi version installed that would be
used instead.
Also, we pop the 0'th element after the jedi import, so it it was
previously incorrect and would pop the wrong entry from sys.path.