faster image compression when alwaysKeepResolution is set to true #221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
alwaysKeepResolution
field is set totrue
, existing code tries to decrease thequality
linearly.maxSizeMB
(see PNG Not compressing to the max Size specified #176 )To improve the performance in this special case, we used binary search on
quality
based on the notionOur target is
quality
where the compressed image file size is lower thanmaxSizeMB
in O(log n) timeDemo improvements:
alwaysKeepResolution
, that allows to change quality without reducing resolution