fix: resolve cases when comparing arrays to non-array values #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoneDeal0
approved these changes
Jun 24, 2024
|
Well spotted @mfactorial ! Thank you very much for your pull request! ps: I will publish a new release when #19 is fixed, so we only bump the lib once. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, I encountered a bug while comparing two objects using
getObjectDiff. In theprevDataobject, a property had an array value, while in thenextDataobject, the same property had a non-array value. TheisEqualfunction failed because it only checks if valueais an array. Ifais an array, it attempts to get the length of valueb, which causes an error whenbis not an array.This fix ensures that the comparison logic correctly handles cases where an array is compared to a non-array value, preventing such errors.