Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: Enable multi-platform image support with in-docker Go com… #56

Closed
wants to merge 1 commit into from
Closed

Dockerfile: Enable multi-platform image support with in-docker Go com… #56

wants to merge 1 commit into from

Conversation

Tycale
Copy link
Contributor

@Tycale Tycale commented Jun 18, 2024

Multi-platform image

docker build --platform linux/amd64,linux/arm64 -t x/k8s-pause:TAG

@Tycale
Dockerfile: Enable multi-platform image support with in-docker Go com…
7e5323f 
…pilation

Signed-off-by: Thibault Gérondal <thibault@initia.cloud>
@Tycale Tycale requested a review from a team as a code owner June 18, 2024 07:57
raffis
raffis reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@raffis raffis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building the binaries here is the wrong approach.
The artifacts are built via goreleaser (see .goreleaser config).

@Tycale
Copy link
Contributor Author

Tycale commented Jun 18, 2024

Ok, I needed to have a release multi-platform, I though it was not handled but it actually is with Goreleaser.

@Tycale Tycale closed this Jun 18, 2024
@Tycale Tycale deleted the multi_plateform branch June 18, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raffis raffis raffis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tycale @raffis