Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang-format 17.0.2 #60

Merged
merged 6 commits into from
Dec 21, 2023
Merged

Add clang-format 17.0.2 #60

merged 6 commits into from
Dec 21, 2023

Conversation

alemuntoni
Copy link
Contributor

No description provided.

@offa
Copy link

offa commented Nov 27, 2023

@DoozyX could you have a look at this PR? Latest clang-format would be appreciated :-).

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should point to the relative path not your personal path?

Copy link
Owner

@DoozyX DoozyX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix the link?

@alemuntoni
Copy link
Contributor Author

Ooops! Sorry, didn't see that! I just fixed it.

@DoozyX
Copy link
Owner

DoozyX commented Nov 28, 2023

thanks, but still don't think it is working as expected, are you testing it on unix, this is what I got
image

@DoozyX
Copy link
Owner

DoozyX commented Nov 28, 2023

also where does the binary come from, for consistency can you align it with https://github.com/muttleyxd/clang-tools-static-binaries?

@alemuntoni
Copy link
Contributor Author

also where does the binary come from

I downloaded it from the official llvm release on github, since I did not find anywhere from where they came from.

I will align the binary from the link you provided.

@DoozyX
Copy link
Owner

DoozyX commented Nov 28, 2023

thanks, in that case just posting the link should be fine

@alemuntoni
Copy link
Contributor Author

I replaced the binary with the one provided in the https://github.com/muttleyxd/clang-tools-static-binaries repo, which is version 17.0.4.

@DoozyX
Copy link
Owner

DoozyX commented Nov 28, 2023

Also the binary needs to be executable (needs chmod +x)

@alemuntoni
Copy link
Contributor Author

Also the binary needs to be executable (needs chmod +x)

Ops again :D Sorry!

It should be ok now!

@GeckoEidechse
Copy link
Contributor

Closes #64

@DoozyX DoozyX merged commit f6987b4 into DoozyX:master Dec 21, 2023
@DoozyX
Copy link
Owner

DoozyX commented Dec 21, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants