Add write contents permissions to release workflow #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piccirello
reviewed
Nov 1, 2022
.github/workflows/release.yml
Outdated
Comment on lines
18
to
19
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
Can you add this to the individual job, rather than the entire workflow? Also, since you're specifying an allowlist of perms, it'll drop all other perms. Are there any other read perms this workflow will need?
There was a problem hiding this comment.
Great callout 👍 We need to be able to checkout the repo but that should be included in contents: write (because it extends read)
nmanoogian
force-pushed
the
nic/release-permissions
branch
from
c5e5e0b to
f3f2353
Compare
Piccirello
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This permission is required to allow the runner to post the build artifacts to the release.