-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doppler_project_role resource #88
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a couple notes, but no blockers from my perspective. Note that I didn't test this locally though.
docs/resources/project_role.md
Outdated
### Required | ||
|
||
- `name` (String) The name of the Doppler project role | ||
- `permissions` (List of String) A list of Doppler project permissions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we link to the API docs that contain the list of valid permission values here? Would be a nice QoL thing for anyone looking at the TF docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call 👍
doppler/api.go
Outdated
func (client APIClient) CreateProjectMember(ctx context.Context, project string, memberType string, memberSlug string, role string, environments []string) (*ProjectMember, error) { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stray newline.
f79f976
to
704208f
Compare
Force push addresses @watsonian's feedback (and rebuilding the docs also showed that I forgot to run |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [doppler](https://registry.terraform.io/providers/dopplerhq/doppler) ([source](https://togithub.com/DopplerHQ/terraform-provider-doppler)) | required_provider | minor | `~> 1.3.0` -> `~> 1.9.0` | --- ### Release Notes <details> <summary>DopplerHQ/terraform-provider-doppler (doppler)</summary> ### [`v1.9.0`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.9.0) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.8.0...v1.9.0) #### What's Changed - Add Fly.io integration + sync and delete_behavior field by [@​nmanoogian](https://togithub.com/nmanoogian) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/93](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/93) - Update Go version to v1.22 by [@​nmanoogian](https://togithub.com/nmanoogian) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/89](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/89) - Add personal_configs field to environment resource by [@​nmanoogian](https://togithub.com/nmanoogian) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/92](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/92) - Add support for kms_key_id in AWS Secrets Manager and Parameter Store syncs by [@​nmanoogian](https://togithub.com/nmanoogian) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/94](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/94) **Full Changelog**: DopplerHQ/terraform-provider-doppler@v1.8.0...v1.9.0 ### [`v1.8.0`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.8.0) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.7.1...v1.8.0) #### What's Changed - Add service_account_token resource by [@​srevinsaju](https://togithub.com/srevinsaju) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/86](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/86) - Add doppler_project_role resource by [@​nmanoogian](https://togithub.com/nmanoogian) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/88](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/88) - Add webhook resource by [@​kyle-mcguire](https://togithub.com/kyle-mcguire) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/87](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/87) #### New Contributors - 🎉 [@​srevinsaju](https://togithub.com/srevinsaju) made their first contribution in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/86](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/86) - 🎉 [@​kyle-mcguire](https://togithub.com/kyle-mcguire) made their first contribution in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/87](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/87) **Full Changelog**: DopplerHQ/terraform-provider-doppler@v1.7.1...v1.8.0 ### [`v1.7.1`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.7.1) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.7.0...v1.7.1) - Update dependency versions and add import examples by [@​nmanoogian](https://togithub.com/nmanoogian) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/83](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/83) **Full Changelog**: DopplerHQ/terraform-provider-doppler@v1.7.0...v1.7.1 ### [`v1.7.0`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.7.0) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.6.2...v1.7.0) - Add `doppler_secrets_sync_github_actions` resource by [@​watsonian](https://togithub.com/watsonian) in [#​81](https://togithub.com/DopplerHQ/terraform-provider-doppler/issues/81) **Full Changelog**: DopplerHQ/terraform-provider-doppler@v1.6.2...v1.7.0 ### [`v1.6.2`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.6.2) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.6.1...v1.6.2) - Set ForceNew for `doppler_secret` project and config by [@​nmanoogian](https://togithub.com/nmanoogian) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/78](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/78) - Ignore order of project_member environments by [@​rgharris](https://togithub.com/rgharris) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/79](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/79) **Full Changelog**: DopplerHQ/terraform-provider-doppler@v1.6.1...v1.6.2 ### [`v1.6.1`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.6.1) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.6.0...v1.6.1) - Fix typo in User data source docs by [@​rgharris](https://togithub.com/rgharris) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/76](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/76) **Full Changelog**: DopplerHQ/terraform-provider-doppler@v1.6.0...v1.6.1 ### [`v1.6.0`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.6.0) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.5.0...v1.6.0) - Add resources for managing users in groups by [@​rgharris](https://togithub.com/rgharris) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/72](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/72) - chore: Workflows update by [@​ViacheslavKudinov](https://togithub.com/ViacheslavKudinov) in [https://github.com/DopplerHQ/terraform-provider-doppler/pull/75](https://togithub.com/DopplerHQ/terraform-provider-doppler/pull/75) **Full Changelog**: DopplerHQ/terraform-provider-doppler@v1.5.0...v1.6.0 ### [`v1.5.0`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.5.0) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.4.0...v1.5.0) - Added resources for Terraform Cloud sync integrations (thanks to [@​sbrudz](https://togithub.com/sbrudz)!) - Updated auth documentation to include environment variable support (thanks to [@​kaldorn](https://togithub.com/kaldorn)!) ### [`v1.4.0`](https://togithub.com/DopplerHQ/terraform-provider-doppler/releases/tag/v1.4.0) [Compare Source](https://togithub.com/DopplerHQ/terraform-provider-doppler/compare/v1.3.0...v1.4.0) - Updated from Go 1.19 to 1.21 along with some dependency version bumps - Added support for specifying tags to `doppler_secrets_sync_aws_secrets_manager` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/dotkom/monoweb). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Closes ENG-7582