Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Add starred queries in the editor #9

Merged

Conversation

stratoula
Copy link

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

@stratoula stratoula marked this pull request as draft November 4, 2024 08:37
@stratoula stratoula marked this pull request as ready for review November 6, 2024 12:14
@Dosant Dosant merged commit a36d071 into Dosant:d/2024-10-30-esql-favorites Nov 6, 2024
Dosant added a commit that referenced this pull request Jan 16, 2025
## Summary

Extracted from elastic#206411
[[job]](https://buildkite.com/elastic/kibana-pull-request/builds/267344#019469ff-7fb9-4c5d-8569-2e445aab27be)
[[logs]](https://buildkite.com/organizations/elastic/pipelines/kibana-pull-request/builds/267344/jobs/019469ff-7fb9-4c5d-8569-2e445aab27be/artifacts/01946a1c-62fa-4d30-8863-1b40f8c0b924)
Jest Tests #9 / Overview renders correctly when there is no user data
view
This simplifies overview.tsx by refactoring to rtl and removing the
whole snapshot. The snapshot was not useful and the test is still making
sure that the intended component is still rendered. By removing enzyme,
the test now works properly for both react 17 and 18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants