Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide xml tree per config #115

Closed

Conversation

Silvenga
Copy link

Per #104 (comment)

This pull does the following:

  • Creates a new configuration boolean option called xmlTools.treeViewEnabled which defaults at true.
  • Hides the custom XML document view when this value is not false (incorrect values will default at true).

package.json Outdated
@@ -132,7 +137,8 @@
"explorer": [
{
"id": "xmlTreeView",
"name": "XML Document"
"name": "XML Document",
"when": "config.xmlTools.treeViewEnabled != false"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be:

resourceLangId == 'xml' && config.xmlTools.treeViewEnabled != false

@Ilyes512
Copy link

YES, this is exactly what I was about to ask for in Issues :)

@masaeedu
Copy link

Hi @DotJoshJohnson. Anything blocking this PR from being merged?

@pltrant
Copy link

pltrant commented Nov 13, 2017

FYI, it was later discovered resourceLangId does not work in this context per microsoft/vscode#30981.

@julien-c
Copy link

julien-c commented Feb 9, 2018

Would love this as well.

@Silvenga
Copy link
Author

Silvenga commented Feb 9, 2018

I'm not sure if this pull request is required anymore since this feature was released -
image

@DotJoshJohnson
Copy link
Owner

All - This will be taken care of in the v2 release. The explorer will only display for XML files and you will also have the ability to disable the feature completely if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants