Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SA1130 code fix for return statements and arrow expression clauses #2905

Merged
merged 3 commits into from
Mar 1, 2019

Conversation

vweijsters
Copy link
Contributor

Fixes #2902

@sharwell
Copy link
Member

💡 Can you add an additional test for an event with an initializer? I don't think it's going to change anything but it seems like a test gap:

public static event EventHandler StaticEvent = delegate { };
public event EventHandler InstanceEvent = delegate { };

@codecov

This comment has been minimized.

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #2905 into stabilization will decrease coverage by 0.04%.
The diff coverage is 100%.

@@                Coverage Diff                @@
##           stabilization    #2905      +/-   ##
=================================================
- Coverage          97.42%   97.38%   -0.05%     
=================================================
  Files                778      779       +1     
  Lines             100035   100180     +145     
  Branches            3264     3265       +1     
=================================================
+ Hits               97464    97562      +98     
- Misses              1703     1708       +5     
- Partials             868      910      +42

@sharwell
Copy link
Member

sharwell commented Mar 1, 2019

@vweijsters You feeling confident about this one now? 😄

@vweijsters
Copy link
Contributor Author

Should be OK now, but I'm not betting anything on it 😉

@sharwell sharwell merged commit 1204911 into DotNetAnalyzers:stabilization Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants