-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed SA1130 code fix for return statements and arrow expression clauses #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💡 Can you add an additional test for an event with an initializer? I don't think it's going to change anything but it seems like a test gap: public static event EventHandler StaticEvent = delegate { };
public event EventHandler InstanceEvent = delegate { }; |
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## stabilization #2905 +/- ##
=================================================
- Coverage 97.42% 97.38% -0.05%
=================================================
Files 778 779 +1
Lines 100035 100180 +145
Branches 3264 3265 +1
=================================================
+ Hits 97464 97562 +98
- Misses 1703 1708 +5
- Partials 868 910 +42 |
sharwell
reviewed
Feb 27, 2019
StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/ReadabilityRules/SA1130CodeFixProvider.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Feb 27, 2019
StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/ReadabilityRules/SA1130CodeFixProvider.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Mar 1, 2019
StyleCop.Analyzers/StyleCop.Analyzers.Test/ReadabilityRules/SA1130UnitTests.cs
Show resolved
Hide resolved
@vweijsters You feeling confident about this one now? 😄 |
Should be OK now, but I'm not betting anything on it 😉 |
sharwell
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2902