Реализация модели предметной области #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zetroot
commented
Aug 20, 2021
| /// <param name="StartTime">Session starts at this time (with offset from UTC)</param> | ||
| /// <param name="EndTime">Session ends at this time (with offset from UTC)</param> | ||
| public record MeetupSession(Talk Talk, | ||
| DateTimeOffset StartTime, |
There was a problem hiding this comment.
Тут я позволил себе использовать DateTimeOffset, чтобы хоть как-то попытаться решить проблему часовых поясов. Ну и предположил, что все поля будут обязательны
|
Привел нулябельность полей в соответствие со схемами |
ilabutin
reviewed
Aug 23, 2021
| public record Meetup(string Id, | ||
| string Name, | ||
| Community Community, | ||
| IReadOnlyList<Friend> Friends, |
There was a problem hiding this comment.
А можем мы хотя бы теоретически проводить митап без спонсоров? Или в этом случае просто пустой список будет?
There was a problem hiding this comment.
Я предполагаю, что пустой список в этом случае будет достаточно идиоматичен.
|
Черт, я опять проиграл в неравной схватке с git. @ilabutin ты вроде "сквашишь" коммиты, это не должно стать большой проблемой? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
По задаче #130
Модели и логику связей утянул из Auditor