Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments for breaking changes in paradox #172

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Conversation

PhilippBach
Copy link
Member

@PhilippBach PhilippBach commented Jun 4, 2024

This PR contains changes to the doubleml documentation according to DoubleML/doubleml-for-r#194 and DoubleML/doubleml-for-r#195

Comment: Changes to be merged after merging DoubleML/doubleml-for-r#195 and passing checks with dev version of DoubleML for R (merged to main) .

@PhilippBach
Copy link
Member Author

@SvenKlaassen : This PR is currently for target main , i.e., not dev - just to abstract of any other changes on the dev branch. I can also change to dev. I think the changes are independent of the latest changes for the Python package, so it won't matter anyways...

I just would like to merge the PR for R and issue the CRAN release soon, so we can update the user guide both on stable and dev...

Is there anything that would prevent us from deploying the stable and dev version of the docu (once CRAN release was successful)?

@SvenKlaassen
Copy link
Member

If these are only changes for the R-package, I would agree to merge directly into main.
I will update the dev branch afterwards.

@PhilippBach PhilippBach linked an issue Jun 5, 2024 that may be closed by this pull request
1 task
@PhilippBach PhilippBach changed the base branch from main to dev June 7, 2024 09:15
@PhilippBach PhilippBach merged commit 3fb54b3 into dev Jun 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation to changes paradox (breaking)
2 participants