Skip to content

Conversation

@SvenKlaassen
Copy link
Member

@SvenKlaassen SvenKlaassen commented Jun 18, 2024

Description

Removing indirect dependence of sensitivity_plot on sensitivity_analysis by adding new input values rho, level and null_hypothesis.

Moving sensitivity_plot, sensitivity_analysis , _calc_robustness_value and _calc_sensitivity_analysis from DoubleML to DoubleMLFramework class. The computation of confidence intervals over multiple repetitions is now also based on medians not aggregated variances.

Further, this will allow sensitivity analysis for differences in potential outcomes as proposed in #245

Comments

Most of the computations are only valid for identical outcomes and cond. expectations.

PR Checklist

Please fill out this PR checklist (see our contributing guidelines for details).

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • References to related issues or PRs are added.
  • The code passes all (unit) tests.
  • Enhancements or new feature are equipped with unit tests.
  • The changes adhere to the PEP8 standards.

@SvenKlaassen SvenKlaassen requested a review from PhilippBach July 30, 2024 08:50
@SvenKlaassen SvenKlaassen merged commit 20d9864 into main Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants