Skip to content

Conversation

@SvenKlaassen
Copy link
Member

@SvenKlaassen SvenKlaassen commented Oct 10, 2024

Description

The DoubleMLBLP.fit() object now allows to set kwargs for the OLS.fit() method from statsmodels.
Further the default covariance type is set to cov_type='HC0'.

All cate and gate method pass kwargs to DoubleMLBLP.fit() (and use the same default).

Reference to Issues or PRs

Implements #270

PR Checklist

Please fill out this PR checklist (see our contributing guidelines for details).

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • References to related issues or PRs are added.
  • The code passes all (unit) tests.
  • Enhancements or new feature are equipped with unit tests.
  • The changes adhere to the PEP8 standards.

@SvenKlaassen SvenKlaassen added the enhancement extension of existing feature label Oct 10, 2024
@SvenKlaassen SvenKlaassen self-assigned this Oct 10, 2024
@SvenKlaassen SvenKlaassen linked an issue Oct 10, 2024 that may be closed by this pull request
Copy link
Member

@JanTeichertKluge JanTeichertKluge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The changes look good and all checklist items are completed. Thanks!

@SvenKlaassen SvenKlaassen merged commit 0ee11dd into main Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement extension of existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Allow to pass kwargs to BLP models

3 participants