Skip to content

Temporarly fix Scikit-Learn Version to smaller than 1.6.0 #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OliverSchacht merged 1 commit into from
Dec 16, 2024
Merged

Temporarly fix Scikit-Learn Version to smaller than 1.6.0 #279

OliverSchacht merged 1 commit into from
Dec 16, 2024

Conversation

@OliverSchacht
Copy link
Member

@OliverSchacht OliverSchacht commented Dec 16, 2024 •
edited
Loading

Description

Change setup and requirements to require an older version of sci-kit learn to avoid failing unit tests due to xgboost.

Reference to Issues or PRs

#278 and dmlc/xgboost#11093

Comments

XGBoost has a fix on main, we can reverse this as soon as they have a new release.

PR Checklist

  • The title of the pull request summarizes the changes made.
  • The PR contains a detailed description of all changes and additions.
  • References to related issues or PRs are added.
  • The code passes all (unit) tests.
  • Enhancements or new feature are equipped with unit tests.
  • The changes adhere to the PEP8 standards.

@OliverSchacht OliverSchacht merged commit ac8ad10 into main Dec 16, 2024
11 checks passed
@OliverSchacht OliverSchacht mentioned this pull request Dec 16, 2024
Closed
@anntis anntis mentioned this pull request Jan 5, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SvenKlaassen SvenKlaassen SvenKlaassen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OliverSchacht @SvenKlaassen