-
Notifications
You must be signed in to change notification settings - Fork 26
Store estimated models for nuisance parameters #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippBach
reviewed
Nov 1, 2022
PhilippBach
reviewed
Nov 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MalteKurz for preparing the PR. As you indicate in the check boxes of the PR, there are still the tests missing; Either I can do them in the next days myself or I'll add my review to them later (in case you're faster 😃 ). Thanks!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the often requested feature to store the estimated models for nuisance parameters. To use it, call the method
fit()
with optionstore_models=True
. Example:The estimated models can then be found in the attribute
dml_plr_obj$models
:Note that the number of fitted models depends on the settings and the considered model. The outer named list contains one entry for each nuisance part (here
ml_l
andml_m
). For each nuisance part there is a named list containing an entry for each treatment variable (here only'd'
). The next inner part is a list of lengthn_rep
(repeated cross-fitting) and then a list of lengthn_folds
(number of folds per repeated cross fit).PR Checklist
R CMD check
and all (unit) tests (see our contributing guidelines for details).