Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#229: cover empty and less than page size length #232

Merged
merged 2 commits into from
May 28, 2023

Conversation

DougMidgley
Copy link
Owner

PR details

What is the purpose of this pull request? (put an "X" next to an item)

  • Fix
  • Improvements
  • New Feature
  • Documentation updates
  • Other, please explain:

What changes did you make? (Give an overview)

covered empty arrays on first request and also handling of less than page size lengths
fixes #229

@DougMidgley DougMidgley added the bug Something isn't working label May 8, 2023
@DougMidgley DougMidgley requested a review from JoernBerkefeld May 8, 2023 20:47
@DougMidgley DougMidgley linked an issue May 8, 2023 that may be closed by this pull request
Copy link
Collaborator

@JoernBerkefeld JoernBerkefeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert off-topic breaking changes and this is good to merge

Co-authored-by: Jörn Berkefeld <JoernBerkefeld@users.noreply.github.com>
@DougMidgley DougMidgley merged commit 1b497e6 into develop May 28, 2023
@JoernBerkefeld JoernBerkefeld deleted the bug/229-wrong-totalResult branch May 27, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

legacy api might return incorrect totalResult values
2 participants