fix point transform for insert_text to account for affinity (ianstorm…

…taylor#4848)

* fix point transform for insert_text

* add changeset

.changeset/fast-doors-peel.md

@@ -0,0 +1,5 @@
+---
+'slate': minor
+---
+
+fix point transform for insert_text operations to account for affinity

packages/slate/src/interfaces/point.ts

@@ -110,7 +110,11 @@ export const Point: PointInterface = {
         }
 
         case 'insert_text': {
-          if (Path.equals(op.path, path) && op.offset <= offset) {
+          if (
+            Path.equals(op.path, path) &&
+            (op.offset < offset ||
+              (op.offset === offset && affinity === 'forward'))
+          ) {
             p.offset += op.text.length
           }
 

packages/slate/test/interfaces/Point/transform/backward-insert-text-after-point.tsx

@@ -0,0 +1,24 @@
+import { Point } from 'slate'
+
+export const input = {
+  path: [0, 0],
+  offset: 0,
+}
+
+export const test = value => {
+  return Point.transform(
+    value,
+    {
+      type: 'insert_text',
+      path: [0, 0],
+      text: 'a',
+      offset: 1,
+      properties: {},
+    },
+    { affinity: 'backward' }
+  )
+}
+export const output = {
+  path: [0, 0],
+  offset: 0,
+}

packages/slate/test/interfaces/Point/transform/backward-insert-text-at-point.tsx

@@ -0,0 +1,24 @@
+import { Point } from 'slate'
+
+export const input = {
+  path: [0, 0],
+  offset: 1,
+}
+
+export const test = value => {
+  return Point.transform(
+    value,
+    {
+      type: 'insert_text',
+      path: [0, 0],
+      text: 'a',
+      offset: 1,
+      properties: {},
+    },
+    { affinity: 'backward' }
+  )
+}
+export const output = {
+  path: [0, 0],
+  offset: 1,
+}

packages/slate/test/interfaces/Point/transform/backward-insert-text-before-point.tsx

@@ -0,0 +1,24 @@
+import { Point } from 'slate'
+
+export const input = {
+  path: [0, 0],
+  offset: 1,
+}
+
+export const test = value => {
+  return Point.transform(
+    value,
+    {
+      type: 'insert_text',
+      path: [0, 0],
+      text: 'a',
+      offset: 0,
+      properties: {},
+    },
+    { affinity: 'backward' }
+  )
+}
+export const output = {
+  path: [0, 0],
+  offset: 2,
+}

packages/slate/test/interfaces/Point/transform/forward-insert-text-after-point.tsx

@@ -0,0 +1,24 @@
+import { Point } from 'slate'
+
+export const input = {
+  path: [0, 0],
+  offset: 0,
+}
+
+export const test = value => {
+  return Point.transform(
+    value,
+    {
+      type: 'insert_text',
+      path: [0, 0],
+      text: 'a',
+      offset: 1,
+      properties: {},
+    },
+    { affinity: 'forward' }
+  )
+}
+export const output = {
+  path: [0, 0],
+  offset: 0,
+}

packages/slate/test/interfaces/Point/transform/forward-insert-text-at-point.tsx

@@ -0,0 +1,24 @@
+import { Point } from 'slate'
+
+export const input = {
+  path: [0, 0],
+  offset: 1,
+}
+
+export const test = value => {
+  return Point.transform(
+    value,
+    {
+      type: 'insert_text',
+      path: [0, 0],
+      text: 'a',
+      offset: 1,
+      properties: {},
+    },
+    { affinity: 'forward' }
+  )
+}
+export const output = {
+  path: [0, 0],
+  offset: 2,
+}

packages/slate/test/interfaces/Point/transform/forward-insert-text-before-point.tsx

@@ -0,0 +1,24 @@
+import { Point } from 'slate'
+
+export const input = {
+  path: [0, 0],
+  offset: 1,
+}
+
+export const test = value => {
+  return Point.transform(
+    value,
+    {
+      type: 'insert_text',
+      path: [0, 0],
+      text: 'a',
+      offset: 0,
+      properties: {},
+    },
+    { affinity: 'forward' }
+  )
+}
+export const output = {
+  path: [0, 0],
+  offset: 2,
+}

packages/slate/test/interfaces/Range/transform/outward-collapsed.tsx

@@ -0,0 +1,39 @@
+import { Range } from 'slate'
+
+/**
+ * If a collapsed Range is transformed with affinity outward by an insert_text operation, it should expand.
+ */
+
+export const input = {
+  anchor: {
+    path: [0, 0],
+    offset: 1,
+  },
+  focus: {
+    path: [0, 0],
+    offset: 1,
+  },
+}
+export const test = value => {
+  return Range.transform(
+    value,
+    {
+      type: 'insert_text',
+      path: [0, 0],
+      text: 'a',
+      offset: 1,
+      properties: {},
+    },
+    { affinity: 'outward' }
+  )
+}
+export const output = {
+  anchor: {
+    path: [0, 0],
+    offset: 1,
+  },
+  focus: {
+    path: [0, 0],
+    offset: 2,
+  },
+}