Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more features #4

Merged
merged 13 commits into from
Nov 27, 2024
Merged

Add more features #4

merged 13 commits into from
Nov 27, 2024

Conversation

CrazyboyQCD
Copy link
Contributor

@CrazyboyQCD CrazyboyQCD commented Nov 25, 2024

Closes #3

  • More supported targets
  • C API bindings
  • Global cache for downloaded file

build.rs Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
@DouglasDwyer
Copy link
Owner

Thank you for your contribution.

  • Could we gate the bindings generation and bindgen dependency behind a feature flag? That way, libraries like wgpu (which don't need the extra C bindings) won't need to compile the bindgen dependency tree.
  • Have you tested building on other targets? If not, no problem - they can go untested until somebody tries to use them lol - but I would be curious to know which other platforms we guarantee are working.
  • I have added a few other small comments/questions about style. Let's address them before merging :)

@CrazyboyQCD
Copy link
Contributor Author

  • Could we gate the bindings generation and bindgen dependency behind a feature flag? That way, libraries like wgpu (which don't need the extra C bindings) won't need to compile the bindgen dependency tree.

Done.

  • Have you tested building on other targets? If not, no problem - they can go untested until somebody tries to use them lol - but I would be curious to know which other platforms we guarantee are working.

I only tested with msvc but I believe this should work with all windows targets.

src/cbindings.rs Outdated Show resolved Hide resolved
build.rs Outdated Show resolved Hide resolved
@DouglasDwyer
Copy link
Owner

This PR looks good on my end. Do you have any other concerns, or is this ready to merge?

@CrazyboyQCD
Copy link
Contributor Author

No for now, should be ok to merge.

@DouglasDwyer DouglasDwyer merged commit 1088871 into DouglasDwyer:master Nov 27, 2024
@DouglasDwyer
Copy link
Owner

Thanks for making this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for other targets
2 participants