Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [AudioPlayer] Compatible with other framework #2673

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rashagu
Copy link
Contributor

@rashagu rashagu commented Jan 14, 2025

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe: Compatible with other framework

PR description

Compatible with other framework

Changelog

🇨🇳 Chinese

  • Fix: Compatible with other framework

🇺🇸 English

  • Fix: 兼容其他框架,比如vue

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d2545e8:

Sandbox Source
pr-story Configuration

@pointhalo
Copy link
Collaborator

@YyumeiZhang @YannLynn 这块我们加个自定义的 eslint规则吧🤔,把 foundation里对 react的一些引用配成 error直接在提交时禁掉。
现在不同的人维护新组件时,容易在review的时候漏放。@rashagu 都帮我们找过好多次这类问题了😅

@YannLynn
Copy link
Collaborator

@YyumeiZhang @YannLynn 这块我们加个自定义的 eslint规则吧🤔,把 foundation里对 react的一些引用配成 error直接在提交时禁掉。 现在不同的人维护新组件时,容易在review的时候漏放。@rashagu 都帮我们找过好多次这类问题了😅

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants