Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Navbar + fixed mobile #91

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MerlinLeWizard
Copy link
Contributor

As I started to create the mobile navigation I ended up refactoring the whole navbar.

Here are some changes I did:

  • Removed all the unnessary components. You should only have components if they have unique changes to already excisting components are have any benefits / logic. All components where mostly just components wrapped into another.
  • Moved the socials Bluesky and Discord to the footer. There is no need to have 2 serpate social button menu and by moving them into 1 component you keep a consistancy everywhere. It also make sure to save space for mobile use.
  • Remove the theme toggler
    -> This should be under user settings page. A user will usually change the theme occasionally
    -> Save space for mobile
  • Added a hamburger menu for mobile where all pages live
  • Removed the Sign Up button and Changed the text for Log In to Sign Up
    -> This saves space and Sign Up options is already displayed under the Login/Sign up page.
    -> By changing the name Log In to Sign Up a user willl know there is a Sign Up option under that action
  • Added a min-width for the search bar
  • Made it so the 'Join Jam / My Games' and 'Create Post' are moved under the User button on mobile
  • Reworked some logic and mechanics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant