-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript type declarations #21
Conversation
CI failed on older Node.js versions because of |
@Download, have you noticed this PR? I myself very often overlook some PRs/issues in my projects, so I’m better reminding… |
Ehm... yes I did overlook it. Sorry! |
Is there a way to test this? Or better yet... can we make it so that if the type defs go out-of-synch with the code, some test fails? |
What is the status of this merge? The |
I have to find some time to write tests for the type declarations. |
@Download There is not much risk regarding the .d.ts definitions, it could break stuff if existing defs had existed, but because it's the first one, it won't. Also, TS "bugs" are easily fixables using The easiest way to support TS is to build the package in TS, at least you're sure it won't be out of sync. This could/should be merged quickly. Meanwhile, I'll manually add the d.ts file to my project. |
@@ -61,5 +61,8 @@ | |||
"webpack-cli": "^3.1.2", | |||
"webpack-dev-server": "^3.1.10" | |||
}, | |||
"dependencies": {} | |||
"dependencies": {}, | |||
"peerDependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why peerDependencies? Wouldn't devDependencies be better suited since it's only useful for TS typings? Having it in peerDependencies wouldn't increase the overall size while not being actually useful for a production usage?
See #33 |
Depends on Download/anylogger#2
Resolves #19