Ignore synthetic fields on extracting declared fields in ClassLevelFieldMappingGenerator #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garethahealy thanks for merging! Would it be possible to build a release for that and push to maven central? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
[ISSUE: #763] ClassLevelFieldMappingGenerator should ignore synthetic fields
Purpose
Currently ClassLevelFieldMappingGenerator extracts all fields by reflection. This also includes synthetic fields. This causes problems if source code is instrumented e.g. by JaCoCo. For JaCoCo this can lead to out of memory situations.
Approach
As described here in the JaCoCo Faq, the PR ignores synthetic fields in ClassLevelFieldMappingGenerator.
Open Questions and Pre-Merge TODOs