Add a progress bar for mssr (GUI + terminal) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GUI: Only updates at each milestone (Can't modify GUI from numba)
Terminal: Only for CPU, with numba-progress we can display the progress
in each cpu accelerated function
For GPU, only the GUI progress bar is available (but it is faster, so fine)
Dr2-JMM
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milestones are Intepolation, Max difference, Mean Shift
in each cpu accelerated function
For GPU, only the GUI progress bar is available (but it is faster, so fine)
If not interested by the terminal progress bar, we can drop it and drop the numba-progress dependency.