Skip to content

Fix a few wiring problems #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix a few wiring problems #2

wants to merge 3 commits into from

Conversation

ikr
Copy link

@ikr ikr commented Jun 10, 2016

  • Allow npm run server without a global babel-cli – fixes Fails at "npm run server" #1
  • Fix the 404-s on build.js & vendors.js
  • Move <script> into <body> to be more HTML-spec-compliant and keep Firefox dev tools happy

ikr added 3 commits June 10, 2016 14:38
Plug the correct file system path to the Web root
Moved it to the <body>. According to the HTML specification, a
<script>'s parent can be: "Any element that accepts metadata content, or
any element that accepts phrasing content." <html> belongs to neither of
those two. That's why, probably, my FirefoxDeveloperEdition complained.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script

http://stackoverflow.com/a/19985703/6430

Even though <script> right in the <html> probably works almost
everywhere, it's not quite spec-compliant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails at "npm run server"
1 participant