Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds responsetime_threshold to TCP type checks #4

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

mbarper
Copy link

@mbarper mbarper commented Jul 10, 2023

In order to resolve DrFaust92/terraform-provider-pingdom#18 I'm adding responsetime_threshold to TCP type checks

@xesco
Copy link

xesco commented Nov 14, 2023

I believe the problem is not only for responsetime_threshold I am having the same issue setting the userids parameter: the value is ignored for TCP type checks.

@mbarper
Copy link
Author

mbarper commented Nov 14, 2023

This has been opened for 4 months now. I don't think this repository is maintained in any way, is it @DrFaust92?

@DrFaust92
Copy link
Owner

Sorry, i was not tracking this repo

DrFaust92/terraform-provider-pingdom#21

Copy link
Owner

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DrFaust92 DrFaust92 merged commit 8427ab7 into DrFaust92:master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCP checks do not set responsetime_threshold
3 participants