Add AsyncAdapter #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like it could be extremely useful to me! |
|
API LGTM so far. lmk if you want feedback on the implementation when it's ready and I can do a more thorough review. Thanks for this! It's gonna be awesome. :D |
AsyncAdapter can be used to handle Line, Options, and Command events in an asynchronous manner, similar to the main Yarn Spinner implementation. AsyncAdapter is a DialogueHandler that can be passed to VirtualMachine. Then, the user can supply an AsyncDialogueHandler. When Line, Options, or Command is called on the AsyncDialogueHandler, the VM execution is paused, and can continue by calling AsyncAdapter.Go, GoWithChoice, or can be stopped entirely with AsyncAdapter.Abort.
|
@kalexmills have at it! Keen to hear your thoughts. |
kalexmills
approved these changes
May 6, 2023
Aside from consistency, pausing on other events may be useful to show animations, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncAdaptercan be used to handle events in an asynchronous manner, similar to the main Yarn Spinner implementation.AsyncAdapteris aDialogueHandlerthat can be passed toVirtualMachine. Then, the user can supply anAsyncDialogueHandler. Once any of the messages are called on theAsyncDialogueHandler, the VM execution is paused, and can continue by callingGoorGoWithChoiceonAsyncAdapter, or can be stopped entirely withAbort.