Only sync if values are different or future values may be lost

DrNiels · Apr 23, 2018 · de309cc · de309cc
1 parent 63f0422
commit de309cc
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/monaco-editor.html b/monaco-editor.html
@@ -593,8 +593,12 @@
     window.addEventListener('message', ({data}) => {
       if(data.editorReference !== this.editorReference) return;
       if (data.event === 'value-changed') {
-        this.set('_syncValue', true);
-        this.set('value', data.details);
+        // Only sync if the values are different. Otherwise the valueChanged observer won't trigger and
+        // the next change will be used to reset _syncValue instead of setting the desired value
+        if (this.value !== data.details) {
+          this.set('_syncValue', true);
+          this.set('value', data.details);
+        }
       }
       if (data.action === 'editor-focused') {
         this._syncSchema();
@@ -649,8 +653,12 @@
     var model = editor.getModel();
     model.onDidChangeContent(() => {
       if (!this._incomingValue) {
-        this.set('_syncValue', true);
-        this.set('value', model.getValue());
+        // Only sync if the values are different. Otherwise the valueChanged observer won't trigger and
+        // the next change will be used to reset _syncValue instead of setting the desired value
+        if (this.value !== model.getValue()) {
+          this.set('_syncValue', true);
+          this.set('value', model.getValue());
+        }
       } else {
         this.set('_incomingValue', false);
       }